Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement queryRadius and queryIntersectsFeature in heatmap layer #5594

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Implement queryRadius and queryIntersectsFeature in heatmap layer #5594

merged 1 commit into from
Nov 6, 2017

Conversation

asheemmamoowala
Copy link
Contributor

Prevent errors when accidentally invoking queryRenderedFeatures on heatmap layers.

Closes #5473

@jfirebaugh
Copy link
Contributor

Can you add a regression test for this please? A query test with a heatmap layer that expects no results is fine.

mourner
mourner approved these changes Nov 3, 2017
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until we implement querying density values, I think it's good enough a fix for now to unblock the release.

@mourner mourner merged commit 8947699 into master Nov 6, 2017
@mourner mourner deleted the heatmaps-no-query branch November 6, 2017 12:04
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asheemmamoowala @jfirebaugh @mourner