Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support adding SDF images at runtime #5181

Merged
merged 2 commits into from
Aug 23, 2017
Merged

Support adding SDF images at runtime #5181

merged 2 commits into from
Aug 23, 2017

Conversation

lbud
Copy link
Contributor

@lbud lbud commented Aug 22, 2017

We determine whether an icon is an SDF by checking for a sdf boolean in the sprite.json. This PR adds support for adding SDF icons at runtime by adding an sdf options parameter to addImage.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • manually test the debug page

jfirebaugh
jfirebaugh approved these changes Aug 22, 2017
View reviewed changes
Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Scarysize
Copy link

❤️ Nice! We've been waiting for something like this.

@lbud lbud merged commit 0cbc71d into master Aug 23, 2017
@lbud lbud deleted the addImageSDF branch August 23, 2017 19:15
This was referenced Aug 23, 2017
Closed
Merged
@lbud lbud mentioned this pull request Sep 11, 2017
Closed
@jmunowitch jmunowitch mentioned this pull request Sep 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbud @Scarysize @jfirebaugh