Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize getter/setter creation for StructArray elements #5108

Merged
merged 1 commit into from
Aug 7, 2017

Conversation

pirxpilot
Copy link
Contributor

minor optimization in accessor creation code

@jfirebaugh
Copy link
Contributor

benchmark master b93bc45 pirxpilot-optimize-struct-array 991275f
map-load 110 ms 95 ms
style-load 68 ms 61 ms
buffer 940 ms 916 ms
fps 59 fps 59 fps
frame-duration 5.6 ms, 0% > 16ms 5.6 ms, 0% > 16ms
query-point 0.73 ms 0.74 ms
query-box 40.98 ms 40.04 ms
geojson-setdata-small 2 ms 3 ms
geojson-setdata-large 120 ms 95 ms

Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @pirxpilot!

@jfirebaugh jfirebaugh merged commit 0b7e9c3 into mapbox:master Aug 7, 2017
@pirxpilot pirxpilot deleted the optimize-struct-array branch June 18, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants