-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests using Mapbox core styles #5055
Conversation
3555094
to
c36ac29
Compare
This CI result is a false positive: the |
ci-scripts/dependencies.sh
Outdated
@@ -17,6 +17,7 @@ fi | |||
PATH="~/.yarn/bin:$PATH" | |||
|
|||
yarn | |||
cd test/integration && yarn && cd ../.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root package.json
has this dependency which triggers installation of the integration dependencies automatically. Can you adjust the path munging for local://
URLs so that they load from the root node_modules
, making this line unnecessary?
1b94211
to
622a0b3
Compare
All tests are passing now, but I'm still catching this message at the end of the test run:
|
622a0b3
to
3668c9c
Compare
The JavaScript heap out of memory issue happens only on Linux. The backtrace obtained via gdb is not much helpful (even though I had
From a web search, it turns out this sounds like a common issue: I also tried the heap diff technique from memwatch on the code I've inserted in Adding |
@jfirebaugh this should be ready for a 2nd review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete test/integration/yarn.lock
; otherwise looks good.
3668c9c
to
9800504
Compare
This PR implements support for offline core styles to be used as resource for integration tests in our test suite.