Merge "mapbox-gl-style-spec" repository into this repository #3946

lucaswoj · 2017-01-11T00:23:21Z

This PR merges the "mapbox-gl-style-spec" repository into this repository.

Todo Before Merging

Todo Immediately After Merging

publish @mapbox/mapbox-gl-style-spec npm package
mark the mapbox-gl-style-spec npm package as deprecated
migrate mapbox-gl-style-spec issues & PRs
mark the mapbox-gl-style-spec github repo as deprecated
sync master and mb-pages
set up redirects from the old mapbox-gl-style-spec website

Follow-Up PR

move all issues from mapbox-gl to this repo
rename this repo to mapbox-gl
rename s3 bucket mapbox-gl
set up redirects from mapbox-gl-js website to mapbox-gl website

- changes the interface of functions to `f(globals, feature)` - removes the "assert" function - improves perf - pins to an updated style spec - bumps to the v2.1.0

V8 is unable to evaluate large disjunctions, failing with "RangeError: Maximum call stack size exceeded". Fixes #1782

Closes #6, closes #10, ref #8.

This reverts commit e37aa5f. Adding validation of ramp stops was good in spirit, but it breaks some v8 styles. Reverting until v9 where we can make backwards incompatible changes.

Revert "prevent ramp from having duplicate stops"

anandthakker · 2017-01-27T14:04:33Z

There is almost a third option: we could just export the style spec off of the mapboxgl object, since that would leverage the browserify transform pipeline that's already happening when the main mapbox-gl module is built. However, mapbox-gl minifies the spec, stripping out the documentation, and I'm pretty sure Studio needs that stuff.

Hmm... what if we stuck a check for process.env.MGL_INCLUDE_SPEC_DOCS in minify_style_spec.js and then exported the spec & utils from the mapboxgl object? That would allow Studio and other web-based dependents to do:

MGL_INCLUDE_SPEC_DOCS=1 existing_browserify_command ...
and just change require('mapbox-gl-style-spec') to require('mapbox-gl').styleSpec.{reference,validate,...}

Not sure if this is actually any better than option 2, though.

lucaswoj · 2017-01-27T18:11:54Z

Thanks for raising these concerns @anandthakker @tmcw. You've brought to light some points I hadn't considered. My plan of attack:

add a "browserify" field to style spec's package.json which can reliably transform the package into vanilla javascript (done in cc80268)
review public npm packages that depend on style spec, work with the authors of any which use style spec's utility functions, do not use browserify, and need to be run in the browser

jfirebaugh · 2017-01-27T19:26:47Z

js/style-spec/package.json

+          }
+        }
+      ],
+      "unassertify",


Bad trailing comma.

jfirebaugh · 2017-01-27T19:51:45Z

Integration in gl-native looks good: mapbox/mapbox-gl-native@c9f3850.

This turned out to add significant complexity to the gl-native implementation, and never took effect in gl-js due to a bug (#3717). Removing it due to the complexity it would add to gl-native and other implementations, and the following additional rationales: * As a general principle: explicit is better than implicit. * Most users will not be constructing functions by hand anyway. For those that do: * Requiring `"type": "categorical"` is not an undue burden, especially when coupled with a hinting mechanism in the validator as implemented here. * Implicitly supplying `"type": "categorical"` for string domain values introduces a potentially surprising difference between `"stops": [["1", 1], ["2", 2]]` and `"stops": [[1, 1], [2, 2]]`.

# Conflicts: # .gitignore # .npmignore # package.json

…spec version

It’s redundant to style spec docs & prone to becoming out-of-date

…dleware

tristen and others added 30 commits January 5, 2016 11:18

Updated docs/_layouts/default.html

c80874e

Updated docs/_layouts/default.html

71a4ee1

Remove double evaluation interface

f5303e3

- changes the interface of functions to `f(globals, feature)` - removes the "assert" function - improves perf - pins to an updated style spec - bumps to the v2.1.0

Pin to style spec version by SHA, not branch name

5de9d74

Update README.md

086bfcb

Updated docs/_layouts/default.html

b49f940

Updated docs/_layouts/default.html

fcb912f

Avoid large disjunctions when evaluating 'in'

6254b4c

V8 is unable to evaluate large disjunctions, failing with "RangeError: Maximum call stack size exceeded". Fixes #1782

1.0.3

d2e04ec

Updated docs/_layouts/default.html

6b531c5

Add GeoJSON clustering properties to v8

2ff9070

update changelog for 8.4.0

da9a0e0

8.4.0

0b6c814

Updated docs/_layouts/default.html

bcb8562

faster and simpler filter implementation

b4bc18d

Closes #6, closes #10, ref #8.

implement binary search for huge in filters, close #8

2a0e951

add benchmarks

41b7910

bring back empty any = false behavior

5739338

add gitignore, update package.json

69bb575

2.0.0

ecd7f5a

Updated docs/_layouts/default.html

ef23dd1

Revert "prevent ramp from having duplicate stops"

2ced510

This reverts commit e37aa5f. Adding validation of ramp stops was good in spirit, but it breaks some v8 styles. Reverting until v9 where we can make backwards incompatible changes.

Merge pull request #413 from mapbox/ramp-validation

79d7bfd

Revert "prevent ramp from having duplicate stops"

8.4.1

d6f7fbc

coordinates to lon, lat order

25c8df8

Refactor validator to be more modular

0542641

Added paint property and layout property modules

eb1adab

Remove global layer state

bbf9fa0

Remove global constants state

037c6fd

Refactor arguments structure for validators

0371bb0

jfirebaugh reviewed Jan 27, 2017

View reviewed changes

lucaswoj force-pushed the merge-style-spec branch from cc80268 to 09c8ad3 Compare January 27, 2017 19:39

jfirebaugh and others added 2 commits January 30, 2017 16:45

Rearrange files to prepare for GL JS merge

9de1e40

lucaswoj force-pushed the merge-style-spec branch 6 times, most recently from 643e9fa to 293f49d Compare February 1, 2017 00:21

Lucas Wojciechowski added 9 commits January 31, 2017 16:31

Merge branch 'style-spec-master' into merge-style-spec3

d92eb6e

# Conflicts: # .gitignore # .npmignore # package.json

Fix linter & tests

e39befc

Integrate style spec doc generation into main doc generation flow

87f4f6c

remove style spec from package.json & wire GL JS up to bundled style …

dd8d248

…spec version

Remove function README

120fa9c

It’s redundant to style spec docs & prone to becoming out-of-date

eliminate "build-style-spec" script in favor of custom browserify mid…

84d2063

…dleware

Add the ability to publish the style-spec package seperately

9ab56d2

Hide all style-spec stuff from JSDoc

4578f97

Rewrite README.md

ff6da37

lucaswoj force-pushed the merge-style-spec branch from 293f49d to ff6da37 Compare February 1, 2017 00:31

Delete API.md

e207068

lucaswoj merged commit e207068 into master Feb 1, 2017

lucaswoj deleted the merge-style-spec branch February 1, 2017 01:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge "mapbox-gl-style-spec" repository into this repository #3946

Merge "mapbox-gl-style-spec" repository into this repository #3946

lucaswoj commented Jan 11, 2017 •

edited

Loading

anandthakker commented Jan 27, 2017

lucaswoj commented Jan 27, 2017

jfirebaugh Jan 27, 2017

lucaswoj Jan 27, 2017

jfirebaugh commented Jan 27, 2017

Merge "mapbox-gl-style-spec" repository into this repository #3946

Merge "mapbox-gl-style-spec" repository into this repository #3946

Conversation

lucaswoj commented Jan 11, 2017 • edited Loading

Todo Before Merging

Todo Immediately After Merging

Follow-Up PR

anandthakker commented Jan 27, 2017

lucaswoj commented Jan 27, 2017

jfirebaugh Jan 27, 2017

Choose a reason for hiding this comment

lucaswoj Jan 27, 2017

Choose a reason for hiding this comment

jfirebaugh commented Jan 27, 2017

lucaswoj commented Jan 11, 2017 •

edited

Loading