Fix js crash while trying to justify empty lines #3570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to justify empty lines. If we have a text that contains multiple empty lines in the middle, JS crashes in `justifyLine` function. The `start` glyph index is bigger than the `end` index in such a case.
|
Great! Could you also add a test for that? |
|
No problem. Just did =) |
mourner
approved these changes
Nov 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to justify empty lines.
If we have a text that contains multiple empty lines in the middle, JS crashes in
justifyLinefunction.The
startglyph index is bigger than theendindex in such a case.