Fix flicker when rendering image source #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansis
reviewed
Nov 3, 2016
| @@ -36,6 +36,8 @@ function drawRasterTile(painter, sourceCache, layer, coord) { | |||
| const tile = sourceCache.getTile(coord); | |||
| const posMatrix = painter.transform.calculatePosMatrix(coord, sourceCache.getSource().maxzoom); | |||
|
|
|||
| if (!tile.texture) return; | |||
There was a problem hiding this comment.
In what cases does this happen? Should the source not include the tile in the list of renderable tiles?
There was a problem hiding this comment.
Good idea. I can rejigger things to make that the case.
|
mourner
approved these changes
Nov 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a flicker that occurs intermittently when rendering an image source. See #3519 for more info about the bug.
Launch Checklist
image/defaulthas been failing on my machine since DRY up VideoSource code #3353, this PR fixes it)