Worker refactor #3404
Merged
Worker refactor #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
force-pushed
the
worker-refactor
branch
from
317c921
to
e6d6fc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up and simplify
WorkerTile#parse; retain correct layer order throughout the layout process.Fixes #3394.
Launch Checklist
Benchmarks
map-load
master 875edf2: 116 ms
worker-refactor 317c921: 88 ms
style-load
master 875edf2: 95 ms
worker-refactor 317c921: 98 ms
buffer
master 875edf2: 1,065 ms
worker-refactor 317c921: 1,106 ms
fps
master 875edf2: 60 fps
worker-refactor 317c921: 60 fps
frame-duration
master 875edf2: 7.4 ms, 0% > 16ms
worker-refactor 317c921: 7.5 ms, 1% > 16ms
query-point
master 875edf2: 1.03 ms
worker-refactor 317c921: 1.15 ms
query-box
master 875edf2: 88.51 ms
worker-refactor 317c921: 90.13 ms
geojson-setdata-small
master 875edf2: 8 ms
worker-refactor 317c921: 7 ms
geojson-setdata-large
master 875edf2: 103 ms
worker-refactor 317c921: 96 ms