fix missing icon collision boxes #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansis
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Jan 23, 2016
ChrisLoer
added a commit
that referenced
this pull request
Aug 17, 2017
…ust use a single collision box for them, instead of trying to approximate the shape of the icon with multiple collision boxes. This makes the behavior similar to point icons with rotation-alignment map, which depend on having a roughly square shape (see issue #4861).
ChrisLoer
added a commit
that referenced
this pull request
Sep 5, 2017
…ust use a single collision box for them, instead of trying to approximate the shape of the icon with multiple collision boxes. This makes the behavior similar to point icons with rotation-alignment map, which depend on having a roughly square shape (see issue #4861).
ChrisLoer
added a commit
that referenced
this pull request
Sep 15, 2017
…ust use a single collision box for them, instead of trying to approximate the shape of the icon with multiple collision boxes. This makes the behavior similar to point icons with rotation-alignment map, which depend on having a roughly square shape (see issue #4861).
ChrisLoer
added a commit
that referenced
this pull request
Sep 22, 2017
…ust use a single collision box for them, instead of trying to approximate the shape of the icon with multiple collision boxes. This makes the behavior similar to point icons with rotation-alignment map, which depend on having a roughly square shape (see issue #4861).
ChrisLoer
added a commit
that referenced
this pull request
Sep 27, 2017
…ust use a single collision box for them, instead of trying to approximate the shape of the icon with multiple collision boxes. This makes the behavior similar to point icons with rotation-alignment map, which depend on having a roughly square shape (see issue #4861).
ChrisLoer
added a commit
that referenced
this pull request
Sep 28, 2017
…ust use a single collision box for them, instead of trying to approximate the shape of the icon with multiple collision boxes. This makes the behavior similar to point icons with rotation-alignment map, which depend on having a roughly square shape (see issue #4861).
ChrisLoer
added a commit
that referenced
this pull request
Sep 29, 2017
…ust use a single collision box for them, instead of trying to approximate the shape of the icon with multiple collision boxes. This makes the behavior similar to point icons with rotation-alignment map, which depend on having a roughly square shape (see issue #4861).
ChrisLoer
added a commit
that referenced
this pull request
Sep 29, 2017
- Collision detection now runs on the foreground in a global, viewport-aligned CollisionIndex instead of in the background on map-aligned CollisionTiles. - Calculating label size at render time means it's no longer necessary to approximate perspective effects - Splits symbol_bucket#prepare and symbol_bucket#place into separate files. - Background processing of symbol_bucket, including buffer generation, is now completed with 'prepare' - 'place' is now called on the foreground in preparation for render calls. - Placement now updates dynamic opacity buffers instead of re-generating large static buffers - Line label projection code from 'projection.js' is now used during Placement to calculate the extent of line labels - Vertical and horizontal versions of glyphs are now generated at same time in the background. At render time, one version will be hidden based on line angle. - Rolls back PR #1981: even when icons are rotation-aligned to a line, just use a single collision box for them, instead of trying to approximate the shape of the icon with multiple collision boxes. This makes the behavior similar to point icons with rotation-alignment map, which depend on having a roughly square shape (see issue #4861).
ChrisLoer
added a commit
that referenced
this pull request
Oct 3, 2017
- Collision detection now runs on the foreground in a global, viewport-aligned CollisionIndex instead of in the background on map-aligned CollisionTiles. - Calculating label size at render time means it's no longer necessary to approximate perspective effects - Splits symbol_bucket#prepare and symbol_bucket#place into separate files. - Background processing of symbol_bucket, including buffer generation, is now completed with 'prepare' - 'place' is now called on the foreground in preparation for render calls. - Placement now updates dynamic opacity buffers instead of re-generating large static buffers - Line label projection code from 'projection.js' is now used during Placement to calculate the extent of line labels - Vertical and horizontal versions of glyphs are now generated at same time in the background. At render time, one version will be hidden based on line angle. - Rolls back PR #1981: even when icons are rotation-aligned to a line, just use a single collision box for them, instead of trying to approximate the shape of the icon with multiple collision boxes. This makes the behavior similar to point icons with rotation-alignment map, which depend on having a roughly square shape (see issue #4861).
ChrisLoer
added a commit
that referenced
this pull request
Oct 5, 2017
- Collision detection now runs on the foreground in a global, viewport-aligned CollisionIndex instead of in the background on map-aligned CollisionTiles. - Calculating label size at render time means it's no longer necessary to approximate perspective effects - Splits symbol_bucket#prepare and symbol_bucket#place into separate files. - Background processing of symbol_bucket, including buffer generation, is now completed with 'prepare' - 'place' is now called on the foreground in preparation for render calls. - Placement now updates dynamic opacity buffers instead of re-generating large static buffers - Line label projection code from 'projection.js' is now used during Placement to calculate the extent of line labels - Vertical and horizontal versions of glyphs are now generated at same time in the background. At render time, one version will be hidden based on line angle. - Rolls back PR #1981: even when icons are rotation-aligned to a line, just use a single collision box for them, instead of trying to approximate the shape of the icon with multiple collision boxes. This makes the behavior similar to point icons with rotation-alignment map, which depend on having a roughly square shape (see issue #4861).
ChrisLoer
added a commit
that referenced
this pull request
Oct 6, 2017
- Collision detection now runs on the foreground in a global, viewport-aligned CollisionIndex instead of in the background on map-aligned CollisionTiles. - Calculating label size at render time means it's no longer necessary to approximate perspective effects - Splits symbol_bucket#prepare and symbol_bucket#place into separate files. - Background processing of symbol_bucket, including buffer generation, is now completed with 'prepare' - 'place' is now called on the foreground in preparation for render calls. - Placement now updates dynamic opacity buffers instead of re-generating large static buffers - Line label projection code from 'projection.js' is now used during Placement to calculate the extent of line labels - Vertical and horizontal versions of glyphs are now generated at same time in the background. At render time, one version will be hidden based on line angle. - Rolls back PR #1981: even when icons are rotation-aligned to a line, just use a single collision box for them, instead of trying to approximate the shape of the icon with multiple collision boxes. This makes the behavior similar to point icons with rotation-alignment map, which depend on having a roughly square shape (see issue #4861).
ChrisLoer
added a commit
that referenced
this pull request
Oct 17, 2017
- Collision detection now runs on the foreground in a global, viewport-aligned CollisionIndex instead of in the background on map-aligned CollisionTiles. - Calculating label size at render time means it's no longer necessary to approximate perspective effects - Splits symbol_bucket#prepare and symbol_bucket#place into separate files. - Background processing of symbol_bucket, including buffer generation, is now completed with 'prepare' - 'place' is now called on the foreground in preparation for render calls. - Placement now updates dynamic opacity buffers instead of re-generating large static buffers - Line label projection code from 'projection.js' is now used during Placement to calculate the extent of line labels - Vertical and horizontal versions of glyphs are now generated at same time in the background. At render time, one version will be hidden based on line angle. - Rolls back PR #1981: even when icons are rotation-aligned to a line, just use a single collision box for them, instead of trying to approximate the shape of the icon with multiple collision boxes. This makes the behavior similar to point icons with rotation-alignment map, which depend on having a roughly square shape (see issue #4861).
ChrisLoer
added a commit
that referenced
this pull request
Oct 18, 2017
- Collision detection now runs on the foreground in a global, viewport-aligned CollisionIndex instead of in the background on map-aligned CollisionTiles. - Calculating label size at render time means it's no longer necessary to approximate perspective effects - Splits symbol_bucket#prepare and symbol_bucket#place into separate files. - Background processing of symbol_bucket, including buffer generation, is now completed with 'prepare' - 'place' is now called on the foreground in preparation for render calls. - Placement now updates dynamic opacity buffers instead of re-generating large static buffers - Line label projection code from 'projection.js' is now used during Placement to calculate the extent of line labels - Vertical and horizontal versions of glyphs are now generated at same time in the background. At render time, one version will be hidden based on line angle. - Rolls back PR #1981: even when icons are rotation-aligned to a line, just use a single collision box for them, instead of trying to approximate the shape of the icon with multiple collision boxes. This makes the behavior similar to point icons with rotation-alignment map, which depend on having a roughly square shape (see issue #4861).
VictorHom
pushed a commit
to VictorHom/mapbox-gl-js
that referenced
this pull request
Oct 27, 2017
- Collision detection now runs on the foreground in a global, viewport-aligned CollisionIndex instead of in the background on map-aligned CollisionTiles. - Calculating label size at render time means it's no longer necessary to approximate perspective effects - Splits symbol_bucket#prepare and symbol_bucket#place into separate files. - Background processing of symbol_bucket, including buffer generation, is now completed with 'prepare' - 'place' is now called on the foreground in preparation for render calls. - Placement now updates dynamic opacity buffers instead of re-generating large static buffers - Line label projection code from 'projection.js' is now used during Placement to calculate the extent of line labels - Vertical and horizontal versions of glyphs are now generated at same time in the background. At render time, one version will be hidden based on line angle. - Rolls back PR mapbox#1981: even when icons are rotation-aligned to a line, just use a single collision box for them, instead of trying to approximate the shape of the icon with multiple collision boxes. This makes the behavior similar to point icons with rotation-alignment map, which depend on having a roughly square shape (see issue mapbox#4861).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1978
The real bug in #1978 is #1980 but this improvement also happens to fix #1978.
Icons that are aligned with lines don't actually curve along lines. Instead of creating the collision boxes along the actual line, this creates them along a straight line that is aligned with the middle segment.