Relaxed tolerance allowing four new render tests to pass on GL-Native linux #11376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SnailBones
added
the
skip changelog
ryanhamley
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
The new feature-state tests introduced in #11049 and #11359 were failing.
This is caused by differences in antialiasing of different operating systems. Interestingly, it occurs in this case only when zoom > 0, possibly because it stems from the way that different operating systems handle subpixel floating point values.
This behavior is an existing and acceptable difference as demonstrated by other tests such as this one:
This change increased the tolerance to enable these tests to pass.
Similar to #11308