Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use named exports for style-spec entrypoint module #6601

Closed
anandthakker opened this issue May 3, 2018 · 1 comment
Closed

Use named exports for style-spec entrypoint module #6601

anandthakker opened this issue May 3, 2018 · 1 comment
Labels
release blocker ⛔

Comments

@anandthakker
Copy link
Contributor

anandthakker commented May 3, 2018 •
edited
Loading

Currently, because style-spec.js uses a default export, the compiled bundle's exports are behind default -- i.e., you have to do const validate = require('style-spec').default.validate instead of const validate = require('style-spec').validate.

Switching to named exports should restore the expected bundling behavior, and anyway is in line with #6336
@anandthakker
Copy link
Contributor Author

cc @mapbox/maps-api

anandthakker pushed a commit that referenced this issue May 3, 2018
Use named exports in style-spec.js
2cb6197 
Fixes #6601
@anandthakker anandthakker mentioned this issue May 3, 2018
Merged
anandthakker pushed a commit that referenced this issue May 3, 2018
Use named exports in style-spec.js
11e045e 
Fixes #6601
anandthakker added a commit that referenced this issue May 3, 2018
@anandthakker
Use named exports in style-spec.js (#6602)
535ba4a 
Fixes #6601
anandthakker added a commit that referenced this issue May 3, 2018
@anandthakker
Use named exports in style-spec.js (#6602)
035be95 
Cherry pick e83054f from master

Fixes #6601
anandthakker added a commit that referenced this issue May 3, 2018
@anandthakker
Cherry pick style-spec build fixes from master (#6603)
3bd1803 
* Fix style-spec build (#6575)

* Ensure style-spec is published with mapbox-gl (#6586)

Cherry pick 478dd56 from master

* Ensure style spec is published with build

Closes #6433
Closes #6574

* Consolidate build unit test commands

* Workaround CI image path bash/sh issue

mapbox/mbgl-ci-images#17

* Bump style-spec version to 12.0.0-pre.1 (#6595)

* Use named exports in style-spec.js (#6602)

Cherry pick e83054f from master

Fixes #6601

* Ignore whole /dist/ directory

Done in master with e83054f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release blocker ⛔
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anandthakker