Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text-offset kills performance? #562

Closed
nickidlugash opened this issue Jul 16, 2014 · 2 comments
Closed

text-offset kills performance? #562

nickidlugash opened this issue Jul 16, 2014 · 2 comments
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Milestone

Comments

@nickidlugash
Copy link

Specifically, together with "symbol-placement": "line" and "text-rotation-alignment": "viewport", this completely kills performance. It seems to be fine otherwise.

@mourner mourner added this to the v0.1.0 milestone Jul 24, 2014
@mourner
Copy link
Member

mourner commented Jul 24, 2014

@ansis @nickidlugash have we figured this out? Was it generally fixed by the recent performance improvements?

@ansis
Copy link
Contributor

ansis commented Jul 24, 2014

text-offset doesn't have a performance impact itself, so the only thing I can think of is that fixing the offset lead to more text being placed, which killed performance. I wasn't able to reproduce this now, so its possible to performance improvements solved this. text-offset should be safe to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

No branches or pull requests

3 participants