Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels and icons fade out and in #5491

Closed
ttsirkia opened this issue Oct 20, 2017 · 9 comments
Closed

Labels and icons fade out and in #5491

ttsirkia opened this issue Oct 20, 2017 · 9 comments

Comments

@ttsirkia
Copy link

ttsirkia commented Oct 20, 2017

mapbox-gl-js version:

3e51b6c

Steps to Trigger Behavior

  1. Call setFilter (and open a popup which seems to be irrelevant)

Expected Behavior

The map remains the same, the popup opens.

Actual Behavior

All labels and icons in one specific data source fade out with a transition animation and instantly back in.

mapbox-bug

The purple circle and its text as well as the gray labels are in different data source (vector tile) than the blinking elements which are all in the same vector tile.

@anandthakker
Copy link
Contributor

Thanks for reporting this issue @ttsirkia !

Could you please provide self-contained example reproducing this issue? Having an example to work with will make it much more likely that we can successfully diagnose and solve the problem.

@ttsirkia
Copy link
Author

Was this closed because this has been fixed or I haven't had time to create JSFiddle example?

@jfirebaugh
Copy link
Contributor

Hi @ttsirkia, thanks for responding. We get a lot of issues that don't have enough information to diagnose and fix the reported issue, so we close issues labeled "needs information" after a while without a response (a week or so). If you find the time to create a JSFiddle we'll be happy to reopen the issue and investigate.

@ttsirkia
Copy link
Author

It seems tricky to create a minimal example but I found the position in the commit history when this appears. Commit 2835484 is the last one that works, 1355618 does not produce a working build and the next commit 3e51b6c has this bug.

@ttsirkia
Copy link
Author

You can see the issue here: https://julia.dy.fi/map/view?mode=bulletins#13.94/60.0685/23.663 Just hover mouse above those purple circles as in the GIF animation. Commit 3e51b6c is in use.

@jfirebaugh jfirebaugh reopened this Oct 28, 2017
@jfirebaugh
Copy link
Contributor

cc @ChrisLoer @ansis

@ansis
Copy link
Contributor

ansis commented Oct 30, 2017

thanks for the example @ttsirkia

I think the map.setFilter(...) is triggering a tile reload which CrossTileSymbolIndex is not handling properly. @ChrisLoer I think we can fix this when porting the -native CrossTileSymbolIndex changes back to -js.

@ttsirkia
Copy link
Author

Yes, I confirm that commenting out setFilter resolved the issue so the bug is there, not showing the popup. Thanks for investing the issue! I replaced the Mapbox script with version 0.41.0 but I'm happy to test this again when there is a patch available.

@ChrisLoer ChrisLoer added this to the v0.42 milestone Oct 31, 2017
@ChrisLoer ChrisLoer self-assigned this Oct 31, 2017
@jfirebaugh
Copy link
Contributor

This issue can also be observed on the "Filter features within map view" example. http://localhost:8080/mapbox-gl-js/example/filter-features-within-map-view/, if you run yarn start-docs locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants