Flying ends on window resize and browser zoom change

[clif-os]

0.31.0:

Steps to Trigger Behavior

1. start a flying event
2. resize the window or change the browser zoom level

Expected Behavior

I expect that the flying event would continue as normal

Actual Behavior

The flying event ends mid-flight

Flight end on window resize: https://gyazo.com/6fc4e12952b42a6ac1ffe5e790bbb39e

[mollymerp]

Yes, I have noticed this as well. Any keyboard/mouse map interaction cancels an in progress animation. We should probably document or fix this behavior.

[andrewharvey]

This is the root cause for the Mapbox Geocoder not working on Android, so fixing this (ensuring camera animations continue even while the window is resizing) should fix #4481.

[andrewharvey]

Investigating this, removing the stop() call at

mapbox-gl-js/src/ui/map.js

Line 1672 in a48c14c

this.stop().resize()._update();

prevents the flyTo from stopping due to a browser window resize.

It doesn't seem to have any ill affects doing this apart from scroll zoom no longer cancelling the animation. Panning will still cancel the animation.

Doing this it looses the logic which retains the center when resizing, but that might be fixable, and at least is no worse than the current bug.

Since the current behaviour causes #4481 which I feel is a pretty serious bug, are there any thoughts on pushing through this fix with a bit more testing and polish?