error if invalid 'before' argument is passed to Map#addLayer (#5401)

error if invalid 'before' argument is passed to Map#addLayer
mapbox · Oct 5, 2017 · dff1fa4 · dff1fa4
1 parent 5f5a1f6
commit dff1fa4
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/src/style/style.js b/src/style/style.js
@@ -568,7 +568,13 @@ class Style extends Evented {
 
         layer.setEventedParent(this, {layer: {id: id}});
 
+
         const index = before ? this._order.indexOf(before) : this._order.length;
+        if (before && index === -1) {
+            this.fire('error', { message: new Error(`Layer with id "${before}" does not exist on this map.`)});
+            return;
+        }
+
         this._order.splice(index, 0, id);
 
         this._layers[id] = layer;

diff --git a/test/unit/style/style.test.js b/test/unit/style/style.test.js
@@ -1006,6 +1006,28 @@ test('Style#addLayer', (t) => {
         });
     });
 
+    t.test('fire error if before layer does not exist', (t) => {
+        const style = new Style(new StubMap());
+        style.loadJSON(createStyleJSON({
+            layers: [{
+                id: 'a',
+                type: 'background'
+            }, {
+                id: 'b',
+                type: 'background'
+            }]
+        }));
+        const layer = {id: 'c', type: 'background'};
+
+        style.on('style.load', () => {
+            style.on('error', (error)=>{
+                t.match(error.message, /does not exist on this map/);
+                t.end();
+            });
+            style.addLayer(layer, 'z');
+        });
+    });
+
     t.test('fires an error on non-existant source layer', (t) => {
         const style = new Style(new StubMap());
         style.loadJSON(util.extend(createStyleJSON(), {