Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update event schema #529

Merged
merged 9 commits into from
Sep 13, 2024
Merged

Update event schema #529

merged 9 commits into from
Sep 13, 2024

Conversation

mpothier
Copy link
Contributor

@mpothier mpothier commented Sep 11, 2024

Description

  • Updates the event schema to version 2.2 for keystroke and select events. Added some validation to payload constructions to ensure server compatibility.
  • Enable logging with filters and localGeocoder results mixed in. This is made possible by tagging a _source for Mapbox results to distinguish from client-added results.
  • briefly describe the changes in this PR
  • write tests for all new functionality
  • run npm run docs and commit changes to API.md
  • update CHANGELOG.md with changes under master heading before merging

Copy link

@mmarkov mmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm;

lib/events.js Outdated Show resolved Hide resolved
lib/index.js Show resolved Hide resolved
@mpothier mpothier merged commit aaa5b91 into main Sep 13, 2024
2 checks passed
@mpothier mpothier deleted the update-event-schema branch September 13, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants