Fix a line clipping edge case #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
force-pushed
the
mikhail_fix_line_string_clip
branch
from
59db77c
to
937a23c
Compare
mourner
approved these changes
May 11, 2021
pozdnyakov
force-pushed
the
mikhail_fix_line_string_clip
branch
from
937a23c
to
18c8cb9
Compare
Fix the edge case when a line string enters the clip region from outside and has a node exactly on the clip region border. Before, the node on the border was skipped, which caused wrong line metrics estimation.
This was referenced May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the edge case when a line string enters the clip region from outside and has a node exactly on the clip region border.
Before, the node on the border was skipped, which caused wrong line metrics estimation.