Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'in' Filters with too many elements fail with "Uncaught RangeError" #7

Closed
wants to merge 5 commits into from
Closed

'in' Filters with too many elements fail with "Uncaught RangeError" #7

wants to merge 5 commits into from

Commits on Jan 12, 2016

  1. 'in' Filters with too many elements fail with "Uncaught RangeError: M… 

    …aximum call stack size exceeded"

Fixes mapbox/mapbox-gl-js#1782
    @peckjon
    peckjon committed Jan 12, 2016
    Configuration menu
    Copy the full SHA
    814cd0b View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2016

  1. 'in' Filters with too many elements fail with "Uncaught RangeError" 

    Fixes mapbox/mapbox-gl-js#1782

If too many elements (varies by environment, but appx 1-2k) are used for an 'in' filter, it will fail with "Uncaught RangeError: Maximum call stack size exceeded". This is because the logical comparison of many infix comarisons (eg "(p['foo']==='bar') || (p['foo']==='cat') || ...") becomes too long for the v8natives to handle.
    @peckjon
    peckjon committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    05ecf41 View commit details
    Browse the repository at this point in the history

  2. short-circuit evaluation

    @peckjon
    peckjon committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    353ef16 View commit details
    Browse the repository at this point in the history

  3. short-circuit evaluation

    @peckjon
    peckjon committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    dedc21e View commit details
    Browse the repository at this point in the history

  4. Tests for many elements (2000) inside 'in' and '!in' filter

    @peckjon
    peckjon committed Jan 13, 2016
    Configuration menu
    Copy the full SHA
    15fb5c7 View commit details
    Browse the repository at this point in the history