Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Little bug fixes #63

Merged
merged 4 commits into from
Nov 13, 2018
Merged

Little bug fixes #63

merged 4 commits into from
Nov 13, 2018

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Nov 12, 2018

72b9f9a fixes #61

delay-sticky

39eb8dc fixes #57

screen shot 2018-11-12 at 11 36 45 am

@@ -8,7 +8,8 @@ class PageLayout extends React.Component {
constructor(props) {
super(props);
this.state = {
bottomBoundaryValue: 0
bottomBoundaryValue: 0,
enabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth giving this a more descriptive name for your future debugging self?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh yes yes good idea.

Copy link
Contributor

@danswick danswick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🐩 Left one inline comment for you to consider. Also wondering if it might be worth adding a test case with headings way down the page in order to test this?

@colleenmcginnis colleenmcginnis merged commit 97513a4 into master Nov 13, 2018
@colleenmcginnis colleenmcginnis deleted the lil-bug-fixes branch November 13, 2018 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstick sidebar content when going to a hash Icon not centered in BackToTopButton
2 participants