This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Adds lil booklet, contact, and troubleshoot images #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danswick
changed the title
danswick
changed the title
colleenmcginnis
approved these changes
Aug 10, 2018
There was a problem hiding this comment.
Looks good @danswick. What do you think about adding a prop to the Note component to hide/show the image on mobile and set the default to hide on mobile? Not necessary, but might be better than wrapping the <BookImage /> in a <div> with responsive classes in md files. 🤷♀️
|
@colleenmcginnis 🤔that could be good. Thinking it might be good to pass in a list of classes to the component, that way you can still handle responsiveness with CSS. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variety is the spice of life. These little images spice up dr-ui's selection of cute SVGs.
I've also added a
heightandwidthprop to all of the images so they can be more easily sized without resorting to dark magic.