This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Prevent extra whitespace in NavigationAccordion for pages with no headings #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colleenmcginnis
requested review from
davidtheclark and
danswick
and removed request for
davidtheclark
danswick
approved these changes
Aug 10, 2018
|
@colleenmcginnis Looks like a good solution to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
@davidtheclark this was happening because I was feeding the
secondLevelItemsprop an empty array. I'm not sure if this is something that should be prevented here or in the documentation style guide itself.