Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

replace description with children and make it required in RelatedPage #239

Merged
merged 6 commits into from
Feb 5, 2020

Conversation

katydecorah
Copy link
Contributor

@katydecorah katydecorah commented Jan 28, 2020

This PR:

  • replaces description with children so that we can wrap the component around content and allow our testing tools to check for spelling, etc.
  • makes children required - the component looks unbalanced without a description and I think the context is important for the user.

fixes #225

QA Checklist

  • No errors logged to console.
  • Component is accessible at mobile-size viewport.
  • Component is accessible at tablet-size viewport.
  • Component is accessible at laptop-size viewport.
  • Component is accessible at big-monitor-size viewport.

Open the test cases app locally on:

  • Chrome, no errors logged to console.
  • Firefox, no errors logged to console.
  • Safari, no errors logged to console.
  • Edge, no errors logged to console.
  • IE11, no errors logged to console.
  • Mobile Safari, no errors logged to console.
  • Android Chrome, no errors logged to console.

@katydecorah katydecorah added this to the v0.26.0 milestone Jan 28, 2020
Katy DeCorah added 2 commits February 3, 2020 20:42
* master:
  Create vimeo modal option for RelatedPage (#236)
  fixes overflow issue in IE11 for RelatedPage (#238)
  Update PR checklist to include Accessibility/Lighthouse score (#241)
* master:
  Create vimeo modal option for RelatedPage (#236)
  fixes overflow issue in IE11 for RelatedPage (#238)
  Update PR checklist to include Accessibility/Lighthouse score (#241)
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow our testing tools to check for spelling

Brill.

@katydecorah katydecorah merged commit 7e631f7 into master Feb 5, 2020
@katydecorah katydecorah deleted the relatedpage-children branch February 5, 2020 00:11
katydecorah pushed a commit that referenced this pull request Feb 5, 2020
* master:
  replace `description` with children and make it required in RelatedPage (#239)
  create playground theme for RelatedPage (#234)
  Create vimeo modal option for RelatedPage (#236)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make RelatedPage accept children rather than description prop
2 participants