Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

remove code formatting from Edit component #228

Merged
merged 4 commits into from
Jan 22, 2020
Merged

Conversation

katydecorah
Copy link
Contributor

@katydecorah katydecorah commented Jan 15, 2020

#226 was a bust. Once dr-ui is compiled, indent.js didn't have default exports for each function and broke on production. Since code formatting the exported code is purely cosmetic, I feel ok with removing it completely.

QA Checklist

  • No errors logged to console.
  • Component is accessible at mobile-size viewport.
  • Component is accessible at tablet-size viewport.
  • Component is accessible at laptop-size viewport.
  • Component is accessible at big-monitor-size viewport.

Open the test cases app locally on:

  • Chrome, no errors logged to console.
  • Firefox, no errors logged to console.
  • Safari, no errors logged to console.
  • Edge, no errors logged to console.
  • IE11, no errors logged to console.
  • Mobile Safari, no errors logged to console.
  • Android Chrome, no errors logged to console.

@katydecorah
Copy link
Contributor Author

@colleenmcginnis I think this is ready to review now. I added a couple fields to CodePen (that are marked as optional, but I think something on their end is not setting them as optional) that seem to fix the issue!

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4ce64e2 did the trick! All is working as expected on the test site. ✅

@katydecorah katydecorah merged commit 254aca8 into master Jan 22, 2020
@katydecorah katydecorah deleted the rm-code-formatting branch January 22, 2020 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants