This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Clean up feedback -> Sentry tags #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colleenmcginnis I'd like to include this in the next release, if you don't mind 👀 |
| @@ -7,6 +7,12 @@ import Icon from '@mapbox/mr-ui/icon'; | |||
| import * as Sentry from '@sentry/browser'; | |||
|
|
|||
| const anonymousId = uuidv4(); // creates an anonymousId fallback if user is not logged or we cant get their info | |||
| const environment = | |||
There was a problem hiding this comment.
I don't understand what the resulting environment does in line 48, but maybe it's just that I don't understand how Sentry.init() works. 🤔
There was a problem hiding this comment.
@colleenmcginnis I can see how it's not clear as it's using shorthand on line 48. We're setting the key environment in the Sentry.init object to the value of environment as declared here. Which could also look like this (but when the value and key are the same, you can set the variable without having a key/value pair):
Sentry.init({
dsn: this.props.feedbackSentryDsn,
environment: environment
});
added 3 commits
January 2, 2020 16:50
* master: Collapse grayed lines in code block (#206) Add a tag component with themes (#216) Add new related page component (#213) Rework Notes themes (#202) Add "tag" option to second and third level headings (#212) Update style of BetaFlag (#207) Add IE11 compatibility for the `Search` component (#203)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
sectionandpreferredLanguage(this will prevent the tag value ofundefinedif the values are unset)feedbackSentryDsnto accept boolean (false) to disable sending text feedback to Sentry (this is added with Platform team in mind)🐌