-
Notifications
You must be signed in to change notification settings - Fork 11
Babel updates: compile helpers, plugins; add plugins #164
Conversation
…erslist in package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested these changes in /ios-sdk. Versions are being sorted correctly and notes look correct in IE11. @katydecorah it's up to you if you want @danswick to take a look, too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait. All works as expected on start
, but I'm seeing a similar error as I was seeing in #165 when I build
:
[17:37:22 Batfish] Error: Webpack compilation error.
../dr-ui/pkg/back-to-top-button/index.js
Module build failed: ReferenceError: Unknown plugin "babel-plugin-transform-react-remove-prop-types" specified in "base" at 4, attempted to resolve relative to "/path/to/folder/dr-ui/pkg/back-to-top-button"
at Array.map (<anonymous>)
@colleenmcginnis I updated this PR with master (which now has the erroring plugin from #165 ) and confirmed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected for me after the most recent changes! Thanks @katydecorah 💃
* master: (24 commits) 0.20.1 Prepare 0.20.1 0.20.0 Prepare 0.20.0 Prevent src/components/syntax-highlighters from being adding to pkg Update WarningImage in GLWrapper Update CHANGELOG.md Add syntax highlighting functions (#172) Add `GLWrapper` and `DemoIframe` components. (#166) compress svg update *-image themes and clean up svg, make IE11 friendly, set default `size` & make it a number [babel] Add babel config to helpers and plugins, add eslint plugins (#164) [Search] Enable babel polyfill on `Search` component (#165) [BackToTopButton] use `window.scroll(x-coord, y-coord)` (#167) Create a note "flavor" for new products or features (#162) [docs] Update webhook staging urls (#161) 0.19.3 Update CHANGELOG.md [Note] replace Object.assign with a function (#159) 0.19.2 ...
* master: Add Browser component (#177) [test-cases app] create `npm run start-legacy` to test in IE11 (#178) Create a video component (#176) 0.20.1 Prepare 0.20.1 0.20.0 Prepare 0.20.0 Prevent src/components/syntax-highlighters from being adding to pkg Update WarningImage in GLWrapper Update CHANGELOG.md Add syntax highlighting functions (#172) Add `GLWrapper` and `DemoIframe` components. (#166) compress svg update *-image themes and clean up svg, make IE11 friendly, set default `size` & make it a number [babel] Add babel config to helpers and plugins, add eslint plugins (#164)
This PR is part of an action item from the IE11 bug postmortem.
src/helpers
andsrc/plugins
files, these were previously copied over.version-sort
helper were failing on IE11 due to an arrow function. I was able to get around it by addingdr-ui
to thebabelInclude
in those repos.src/data
dir, so that is removed fro the build script.object.assign
.To confirm these new Babel changes are working on IE11, I did the following:
npm run build
npm start
and tested in IE11 Browserstack, especially a page using the note component.No hurry in reviewing this PR.