This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
[search] debounce search results #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colleenmcginnis
approved these changes
May 15, 2019
There was a problem hiding this comment.
🎉 Great idea @katydecorah! I checked the requests made in the network tab on the live help site vs. here and saw a big difference in the requests without a noticeable difference in the UI.
katydecorah
pushed a commit
that referenced
this pull request
May 15, 2019
* master: 0.12.2 [search] debounce search results (#129)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets
debounceto 300 to help prevente
ev
eve
ever
every
every l
every le
every let
every lett
every lette
every letter
every letter f
every letter fr
every letter fro
every letter from
every letter from b
every letter from be
every letter from bei
every letter from bein
every letter from being
every letter from being s
every letter from being se
every letter from being sear
every letter from being searc
every letter from being search
every letter from being searche
every letter from being searched
As a result it will take an extra second for results to display, but I think the pay off of preventing unnecessary requests is worth it.