Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Commit

Permalink
[PageLayout] add data attribute to prevent Swiftype from indexing sid…
Browse files Browse the repository at this point in the history
…ebar content (#146)

* make swiftype exclude sidebar content in `PageLayout`

* update snapshots

* Update CHANGELOG.md
  • Loading branch information
Katy DeCorah authored Jun 24, 2019
1 parent d4a61d2 commit e9d8934
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## Master

* Add data attribute to prevent Swiftype from indexing sidebar content on `PageLayout`. [#146](https://github.com/mapbox/dr-ui/pull/146)

## 0.16.2

* Fix bug where `Search` filter was not displaying with the first query.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ exports[`page-layout Basic renders as expected 1`] = `
>
<div
className="col col--4-mm col--12 bg-gray-faint"
data-swiftype-index="false"
>
<div
className="sticky-outer-wrapper"
Expand Down Expand Up @@ -53,6 +54,7 @@ exports[`page-layout Code highlighting test renders as expected 1`] = `
>
<div
className="col col--4-mm col--12 bg-gray-faint"
data-swiftype-index="false"
>
<div
className="sticky-outer-wrapper"
Expand Down Expand Up @@ -121,6 +123,7 @@ exports[`page-layout Common use case renders as expected 1`] = `
>
<div
className="col col--4-mm col--12 bg-gray-faint"
data-swiftype-index="false"
>
<div
className="sticky-outer-wrapper"
Expand Down Expand Up @@ -325,6 +328,7 @@ exports[`page-layout Custom sidebar column size renders as expected 1`] = `
>
<div
className="col col--4-mm col--3-ml col--12 bg-gray-faint"
data-swiftype-index="false"
>
<div
className="sticky-outer-wrapper"
Expand Down Expand Up @@ -372,6 +376,7 @@ exports[`page-layout Custom sidebar column size, too large - default to original
>
<div
className="col col--4-mm col--12 bg-gray-faint"
data-swiftype-index="false"
>
<div
className="sticky-outer-wrapper"
Expand Down Expand Up @@ -419,6 +424,7 @@ exports[`page-layout Custom sidebar column size, too small - default to original
>
<div
className="col col--4-mm col--12 bg-gray-faint"
data-swiftype-index="false"
>
<div
className="sticky-outer-wrapper"
Expand Down Expand Up @@ -466,6 +472,7 @@ exports[`page-layout Many first level items renders as expected 1`] = `
>
<div
className="col col--4-mm col--12 bg-gray-faint"
data-swiftype-index="false"
>
<div
className="sticky-outer-wrapper"
Expand Down
1 change: 1 addition & 0 deletions src/components/page-layout/page-layout.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ class PageLayout extends React.Component {
className={`col col--4-mm ${
sideBarColSize ? `col--${sideBarColSize}-ml` : ''
} col--12 ${props.sidebarTheme}`}
data-swiftype-index="false"
>
<Sticky
enabled={state.stickyEnabled}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ exports[`search Search with \`narrow\` option set renders as expected 2`] = `
>
<div
className="col col--4-mm col--12 bg-gray-faint"
data-swiftype-index="false"
>
<div
className="sticky-outer-wrapper"
Expand Down

0 comments on commit e9d8934

Please sign in to comment.