Changes for managarm cancelable syscalls #884
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no92
reviewed
Aug 11, 2023
| @@ -60,31 +60,42 @@ int sys_waitpid(pid_t pid, int *status, int flags, struct rusage *ru, pid_t *ret | |||
| return ENOSYS; | |||
| } | |||
|
|
|||
| SignalGuard sguard; | |||
| //SignalGuard sguard; | |||
| HEL_CHECK(recv_resp.error()); | ||
|
|
||
| managarm::posix::SvrResponse<MemoryAllocator> resp(getSysdepsAllocator()); | ||
| resp.ParseFromArray(recv_resp.data(), recv_resp.length()); | ||
| if(resp.error() == managarm::posix::Errors::ILLEGAL_ARGUMENTS) { | ||
| return EINVAL; | ||
| } | ||
| if (resp.error() == managarm::posix::Errors::INTERRUPTED) { | ||
| mlibc::infoLogger() << "returning EINT" << frg::endlog; |
There was a problem hiding this comment.
Should we put this behind some debug flag?
|
Yeah there are quite some debug logs left currently 😅 |
ElectrodeYT
approved these changes
Oct 8, 2023
There was a problem hiding this comment.
LGTM
I do have a question, since this is not instantly obvious to me: would this code work without the changes in managarm, or are we looking at circular dependencies here? To my knowledge, merging in the managarm side first would result in some weird behavior.
| @@ -1,3 +1,4 @@ | |||
| #include "mlibc/debug.hpp" | |||
There was a problem hiding this comment.
Is this LSP? In any case, this should be replaced with <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the changes are incomplete and a little unstable, marking it as draft right now.