Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options/ansi: Handle binary specifiers in format strings #1104

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Qwinci
Copy link
Contributor

@Qwinci Qwinci commented Aug 2, 2024

Support C23 binary printf/scanf/strtol specifiers. Depends on managarm/frigg#72 and closes #1103.

@Dennisbonke Dennisbonke added enhancement bugfix This PR fixes a bug labels Aug 3, 2024
@no92
Copy link
Member

no92 commented Aug 14, 2024

This needs a testcase and a rebase.

@Qwinci Qwinci changed the title options/ansi: Handle binary specifiers in printf options/ansi: Handle binary specifiers in format strings Aug 19, 2024
@Qwinci
Copy link
Contributor Author

Qwinci commented Aug 19, 2024

Done. Also added binary support for scanf and strtol.

@Qwinci Qwinci force-pushed the binary-printf branch 5 times, most recently from 0bb5681 to 0083dc6 Compare August 19, 2024 16:42
@mintsuki mintsuki merged commit 295a609 into managarm:master Aug 20, 2024
34 checks passed
@Qwinci Qwinci deleted the binary-printf branch August 20, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR fixes a bug enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unimplemented printf specifier %b
4 participants