Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: prevent linux_kernel_headers from being set to /usr/include #1082

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

no92
Copy link
Member

@no92 no92 commented Jun 12, 2024

No description provided.

Copy link
Member

@Geertiebear Geertiebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels pretty ad-hoc, this is just one of the many paths you could fill in that are bogus. What is this actually protecting against?

@no92
Copy link
Member Author

no92 commented Jun 12, 2024

We've repeatedly run into people trying to supply their system's /usr/include when building a host-mlibc, and it has taken us > 1 question to figure that out; this aims to prevent this common problem.

@Geertiebear
Copy link
Member

I understand the reaction to avoid common errors, but this is not something that should be handled in the build system. I suggest making this a disclaimer in the README instead.

@no92
Copy link
Member Author

no92 commented Aug 7, 2024

Updated the PR with @ArsenArsen's suggestion to use a list of compiler search paths to check against, instead of hardcoding /usr/include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants