Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#16] [Frontend] As a User, I can sign up and sign in/out with a username and password #37

Merged
merged 42 commits into from
Jun 22, 2021

Conversation

malparty
Copy link
Owner

@malparty malparty commented Jun 15, 2021

[#16] [Frontend] As a User, I can sign up and sign in/out with a username and password

What happened

Added responsive user interface for the following views:

  • Sign up
  • Sign in
  • User/edit
  • Layout (header navbar & footer)

Insight

Most of the views are pure bootstrap. Only the footer is a new scss component.
You can test all with the following steps:

  • Navigate to root (auto-redirected to Sign In with a notice)
  • Click Sign Up, register
  • Now you are logged, you can test the nav bar and the top-right user menu
  • Edit your profile

note that the "Forgot your password?" view is not part of this User Story.

Proof Of Work

Sign in Sign Up Errors msg
image image
Navbar Brand Navbar User Menu
image image

Users/edit

image

@malparty malparty added $user-login Authentication: Sign up, sign in and sign out @0.2.0 First usable release. Feature Frontend priority: normal labels Jun 15, 2021
@malparty malparty added this to the 0.2.0 milestone Jun 15, 2021
@malparty malparty self-assigned this Jun 15, 2021
@github-actions
Copy link

github-actions bot commented Jun 15, 2021

2 Warnings
⚠️ spec/support/authentication_helper.rb#L26 - Has approx 8 statements
⚠️ spec/support/authentication_helper.rb#L35 - Is controlled by argument 'password_confirm'

Generated by 🚫 Danger

</a>
</div>
<div class="collapse" id="newPassword">
<% if @minimum_password_length %>
Copy link

@github-actions github-actions bot Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Replace instance variable with local variable

</div>
<div class="collapse" id="newPassword">
<% if @minimum_password_length %>
<em>(<%= "#{@minimum_password_length} #{t('min_char')}" %>)</em>
Copy link

@github-actions github-actions bot Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Replace instance variable with local variable

@malparty malparty merged commit 5fb1d12 into feature/user-login-backend Jun 22, 2021
@malparty malparty modified the milestones: 0.2.0, 0.3.0 Jun 23, 2021
@malparty malparty deleted the feature/user-login-frontend branch June 23, 2021 10:57
@malparty malparty mentioned this pull request Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Frontend priority: normal $user-login Authentication: Sign up, sign in and sign out @0.2.0 First usable release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants