FIX: Changes for DF apache#1

maljac · Dec 11, 2019 · 598317c · 598317c
1 parent adf2cc2
commit 598317c
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 9 deletions.
diff --git a/superset/assets/src/dashboard/actions/dashboardState.js b/superset/assets/src/dashboard/actions/dashboardState.js
@@ -73,14 +73,14 @@ export function fetchFaveStar(id) {
       .then(({ json }) => {
         if (json.count > 0) dispatch(toggleFaveStar(true));
       })
-      .catch(() =>
-        dispatch(
-          addDangerToast(
-            t(
-              'There was an issue fetching the favorite status of this dashboard.',
-            ),
-          ),
-        ),
+      .catch(() => {}
+        // dispatch(
+        //   addDangerToast(
+        //     t(
+        //       'There was an issue fetching the favorite status of this dashboard.',
+        //     ),
+        //   ),
+        // ),
       );
   };
 }

diff --git a/superset/assets/src/dashboard/components/Header.jsx b/superset/assets/src/dashboard/components/Header.jsx
@@ -285,6 +285,11 @@ class Header extends React.PureComponent {
     const userCanSaveAs = dashboardInfo.dash_save_perm;
     const popButton = hasUnsavedChanges;
 
+    // EDIT: Disable the dashboard header
+    if (!userCanSaveAs) {
+      return null;
+    }
+
     return (
       <div className="dashboard-header">
         <div className="dashboard-component-header header-large">

diff --git a/superset/assets/src/dashboard/stylesheets/builder.less b/superset/assets/src/dashboard/stylesheets/builder.less
@@ -28,7 +28,7 @@
   align-items: center;
   justify-content: space-between;
   padding: 0 24px;
-  box-shadow: 0 4px 4px 0 fade(@darkest, @opacity-light); /* @TODO color */
+  // box-shadow: 0 4px 4px 0 fade(@darkest, @opacity-light); /* @TODO color */
 }
 
 .dashboard-content {

diff --git a/superset/assets/src/dashboard/stylesheets/components/header.less b/superset/assets/src/dashboard/stylesheets/components/header.less
@@ -17,6 +17,7 @@
  * under the License.
  */
 .dashboard-component-header {
+  visibility: hidden;
   width: 100%;
   font-weight: @font-weight-bold;
   padding: 16px 0;