Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set default encoding in createHash() #5

Merged
merged 1 commit into from
Feb 23, 2017
Merged

Explicitly set default encoding in createHash() #5

merged 1 commit into from
Feb 23, 2017
+1 −1

Commits on Feb 16, 2017

  1. Explicitly set default encoding in createHash() 

    Up until now, the default encoding for this is `binary`, but
this is scheduled to change in Node 8. Since this module is
currently always passing string input to the `Hash` object,
it needs to account for that.

A better fix would likely involve dropping all strings handling
and treating binary data using Buffer objects, but I kept
this change minimal to avoid any breakage.

Refs: nodejs/node#8611
    @addaleax
    addaleax committed Feb 16, 2017
    Configuration menu
    Copy the full SHA
    2a395e2 View commit details
    Browse the repository at this point in the history