fix/html-twig-templates Some miscellaneous HTML validation correction #6083
+40
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 89398c4.
|
Thanks for contributing! I noticed that you didn't select
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
What does this PR include?
Short Description
A few very simple miscellaneous HTML corrections in the /data/web/templates files. Ideally I would like to see the whole login page validate completely but there are a few items that can't really be fixed.
autocorrect="off"is a non-standard attribute but can help on Apple/Safari browsers.<legend>seems wrongly used in a lot of places but simply removing it has severe styling implications. I fixed as much as possible other bits and pieces.Affected Containers
Since this only affects files served from the Web UI, I guess only following (either/or) containers are affected
Did you run tests?
What did you test?
Checked page rendering of login page to make sure no adverse functionality or styling effect.
What were the final results?
No issues encountered.