Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hard-coding IPV4 and IPV6 rather than it being detected #5895

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

cmer
Copy link

@cmer cmer commented Jun 5, 2024

This allows hardcoding IPV4 and IPV6 rather than being automatically detected when renewing SSL certificates.

This is handy in scenarios where outbound traffic comes from a different IP than what would normally be expected.

@milkmaker
Copy link
Collaborator

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging.
See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

@cmer cmer changed the base branch from master to staging June 5, 2024 18:55
Copy link
Member

@DerLinkman DerLinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this IPs are set so the container can get them?

It needs at least a declaration inside the docker-compose.yml for the Static IPv4/IPv6 adress to be used as a variable inside the container...

@cmer
Copy link
Author

cmer commented Jun 12, 2024

They are environment variables. If not set (this is the default), the IP is automatically resolved. Otherwise, if set, it uses the hardcoded IP in the environment variables.

@dragoangel
Copy link
Collaborator

dragoangel commented Jun 13, 2024

What is the purpose of this change? What are you trying to solve? If you using SNAT properly this should be never the case. Seems to me like a dirty attempt to fix wrong network configuration. For very broken setups there is already option to skip ip check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants