Adding new SKU Mellanox-SN4600C-C4 #14
Conversation
|
Suggest adding the SKU port info like this: You can refer PR 7337 regarding the description. |
|
The buffer pool sizes and SHP sizes are correct. |
In master branch hwsku.json file exists in the SKU folder, but in 202012 branch the file does not exist, so it can not be cherry picked. A new PR for 202012 branch has to be created. I will do it, once master branch, merge happens. |
Addressed it. |
Addressed it. |
|
@liat-grozovik can I take it for approved internally and raise a PR against Azure master? Please let me know. |
There was a problem hiding this comment.
Originally, I focused on the numbers when I was reviewing this PR and didn't realize there are errors in micro names.
@madhanmellanox please adjust it according to my suggestion and open a new PR.
Sorry for the inconvenient
| @@ -0,0 +1,112 @@ | |||
| {% set default_cable = '5m' %} | |||
| {% set ingress_lossless_pool_size = '53379072' %} | |||
| {% set ingress_lossy_pool_size = '1540096' %} | |||
There was a problem hiding this comment.
| {% set ingress_lossy_pool_size = '1540096' %} | |
| {% set ingress_lossless_xoff_size = '1540096' %} |
| "BUFFER_POOL": { | ||
| "ingress_lossless_pool": { | ||
| {%- if dynamic_mode is not defined %} | ||
| "size": "{{ ingress_lossless_pool_size }}", |
There was a problem hiding this comment.
| "size": "{{ ingress_lossless_pool_size }}", | |
| "size": "{{ ingress_lossless_pool_size }}", | |
| "xoff": "{{ ingress_lossless_xoff_size }}", |
| "BUFFER_POOL": { | ||
| "ingress_lossless_pool": { | ||
| {%- if dynamic_mode is not defined %} | ||
| "size": "{{ ingress_lossless_pool_size }}", |
There was a problem hiding this comment.
| "size": "{{ ingress_lossless_pool_size }}", | |
| "size": "{{ ingress_lossless_pool_size }}", | |
| "xoff": "{{ ingress_lossless_xoff_size }}", |
| "type": "ingress", | ||
| "mode": "dynamic" | ||
| }, | ||
| "ingress_lossy_pool": { |
There was a problem hiding this comment.
ingress_lossy_pool section should be removed
| "dynamic_th":"7" | ||
| }, | ||
| "ingress_lossy_profile": { | ||
| "pool":"[BUFFER_POOL|ingress_lossy_pool]", |
There was a problem hiding this comment.
| "pool":"[BUFFER_POOL|ingress_lossy_pool]", | |
| "pool":"[BUFFER_POOL|ingress_lossless_pool]", |
| "BUFFER_PORT_INGRESS_PROFILE_LIST": { | ||
| {% for port in port_names.split(',') %} | ||
| "{{ port }}": { | ||
| "profile_list" : "[BUFFER_PROFILE|ingress_lossless_profile],[BUFFER_PROFILE|ingress_lossy_profile]" |
There was a problem hiding this comment.
| "profile_list" : "[BUFFER_PROFILE|ingress_lossless_profile],[BUFFER_PROFILE|ingress_lossy_profile]" | |
| "profile_list" : "[BUFFER_PROFILE|ingress_lossless_profile]" |
| "BUFFER_POOL": { | ||
| "ingress_lossless_pool": { | ||
| {%- if dynamic_mode is not defined %} | ||
| "size": "{{ ingress_lossless_pool_size }}", |
There was a problem hiding this comment.
| "size": "{{ ingress_lossless_pool_size }}", | |
| "size": "{{ ingress_lossless_pool_size }}", | |
| "xoff": "{{ ingress_lossless_pool_xoff }}", |
| "type": "ingress", | ||
| "mode": "dynamic" | ||
| }, | ||
| "ingress_lossy_pool": { |
There was a problem hiding this comment.
ingress_lossy_pool section should be removed
| "BUFFER_PORT_INGRESS_PROFILE_LIST": { | ||
| {% for port in port_names.split(',') %} | ||
| "{{ port }}": { | ||
| "profile_list" : "[BUFFER_PROFILE|ingress_lossless_profile],[BUFFER_PROFILE|ingress_lossy_profile]" |
There was a problem hiding this comment.
| "profile_list" : "[BUFFER_PROFILE|ingress_lossless_profile],[BUFFER_PROFILE|ingress_lossy_profile]" | |
| "profile_list" : "[BUFFER_PROFILE|ingress_lossless_profile]" |
Why I did it
I did it to add a new SKU Mellanox-SN4600c-c64
How I did it
I developed the SKU based on SKU definitions with the following requirements and tested it on Mellanox 4600C switch.
Port configuration:
• Breakout mode for each port: No
• Speed of the port: 100G
• Auto-negotiation enable/disable: No setting required
• FEC mode: No setting required
• Type of transceiver used: Not needed
Buffer configuration
• Shared headroom enable
• If shared headroom enabled what is the over-subscription ratio as in SN3800
• Dynamic Buffer disable
• In static buffer scenario how many uplinks and downlinks? as in SN3800
• 2km cable support required? no
Switch configuration
• Warmboot enabled? yes
• Should warmboot be added to SAI profile when enabled? yes
• Is VxLAN source port range set? yes
• Should Vxlan source port range be added to SAI profile when set. as in SN3800
• Is Static Policy Based Hashing enabled? no
Number of Uplinks/Downlinks:
How to verify it
Set the SKU in config_db.json to Mellanox-SN4600C-C64 and test the 100G ports coming up on the switch.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Changes are in sonic-buildimage/device/mellanox/x86_64-mlnx_msn4600c-r0/Mellanox-SN4600C-C64/ folder.
A picture of a cute animal (not mandatory but encouraged)