fix(rpc): estimate fee should throw an error if any txn fails (#286)

Co-authored-by: Trantorian1 <114066155+Trantorian1@users.noreply.github.com>

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Next release
 
+- fix: estimate_fee should through an error if any txn fails
 - fix: rejected transaction block production panic
 - fix(sync): pending block retrying mechanism
 - feat(cli): Environment variables can be used to specify Madara parameters

crates/client/rpc/src/versions/v0_7_1/methods/read/estimate_fee.rs

@@ -46,8 +46,19 @@ pub async fn estimate_fee(
 
     let execution_results = exec_context.re_execute_transactions([], transactions, true, validate)?;
 
-    let fee_estimates =
-        execution_results.iter().map(|result| exec_context.execution_result_to_fee_estimate(result)).collect();
+    let fee_estimates = execution_results.iter().enumerate().try_fold(
+        Vec::with_capacity(execution_results.len()),
+        |mut acc, (index, result)| {
+            if result.execution_info.is_reverted() {
+                return Err(StarknetRpcApiError::TxnExecutionError {
+                    tx_index: index,
+                    error: result.execution_info.revert_error.clone().unwrap_or_default(),
+                });
+            }
+            acc.push(exec_context.execution_result_to_fee_estimate(result));
+            Ok(acc)
+        },
+    )?;
 
     Ok(fee_estimates)
 }