Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prerequisites in with-kubeflow deployment doc #307

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

rafvasq
Copy link
Contributor

@rafvasq rafvasq commented Feb 23, 2022

Contributes to #304

I copied the same prerequisites from the Deploy MLX on an existing Kubernetes cluster page, I figured they should provide exactly the same information (e.g. kustomize version)

Rafael Vasquez added 2 commits February 23, 2022 13:58
Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com>
Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com>
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rafael!

@Tomcli @yhwang -- do you have any objections?

Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mlx-bot
Copy link
Collaborator

mlx-bot commented Feb 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mlx-bot mlx-bot merged commit 3a6351a into machine-learning-exchange:main Feb 25, 2022
@rafvasq rafvasq deleted the openshift-link-fix branch March 14, 2022 15:50
krishnakumar27 pushed a commit to krishnakumar27/mlx that referenced this pull request Mar 30, 2022
…g-exchange#307)

* Copy prereq from vanilla deployment

Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com>

* Fix typo

Signed-off-by: Rafael Vasquez <rafael.vasquez@ryerson.com>

Co-authored-by: Rafael Vasquez <rafael.vasquez@ryerson.com>
Signed-off-by: Krishna Kumar <krishnakumar@ibm.com>
@ckadner ckadner added the Jump-Start Work items for Jump-Start participants label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Jump-Start Work items for Jump-Start participants lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants