Add protocols related metrics #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gmetais , thanks for this PR. We can try testing it using nginx and a custom SSL certificate. |
|
@gmetais, please run |
macbre
approved these changes
Nov 2, 2020
|
I thought I would manage to open an SSL port on nginx with a self-signed certificate, but I can't make it work. Any idea why? |
macbre
reviewed
Nov 9, 2020
test/nginx-docker-compose.yaml
Outdated
| @@ -6,7 +6,10 @@ services: | |||
| image: macbre/nginx-brotli:1.19.3 | |||
There was a problem hiding this comment.
Suggested change
| image: macbre/nginx-brotli:1.19.3 | |
| image: macbre/nginx-brotli:1.19.4 |
This solves problems with SSL (1.19.3 image had an issue with nginx build) - see macbre/docker-nginx-http3#15
There was a problem hiding this comment.
@gmetais - now we have
localhost but https version
✗ should be generated
» No error should be thrown: got Error: net::ERR_CERT_AUTHORITY_INVALID at https://127.0.0.1:8889 // /home/runner/work/phantomas/phantomas/node_modules/vows/lib/assert/macros.js:31
We need to pass a different option to puppeteer -> https://github.com/puppeteer/puppeteer/blob/main/docs/api.md#puppeteerlaunchoptions (ignoreHTTPSErrors)
macbre
reviewed
Nov 9, 2020
macbre
reviewed
Nov 9, 2020
macbre
reviewed
Nov 9, 2020
|
Tests now pass 🎉 |
macbre
approved these changes
Nov 9, 2020
|
Huge! Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @macbre,
Congratulations for the release of 2.0.0! 🎉
While working on integrating it into YLT, I thought of this bunch of new metrics. Do you think they could be useful?
I just don't know how to add integration tests for them. Testing on a locally hosted page does not make much sense. Testing on a remote domain could change at any time... Do you have an idea?