-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node.js 14.x integration tests are failing on response size asserts #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2020-08-25T16:36:13.1893140Z /dom-operations.html 2020-08-25T16:36:13.1955120Z ✓ should be generated 2020-08-25T16:36:13.1989632Z ✓ should have "requests" metric properly set 2020-08-25T16:36:13.1990301Z ✓ should have "gzipRequests" metric properly set 2020-08-25T16:36:13.1990900Z ✓ should have "htmlCount" metric properly set 2020-08-25T16:36:13.1991401Z ✗ should have "htmlSize" metric properly set 2020-08-25T16:36:13.1991817Z » expected 2385, 2020-08-25T16:36:13.1992158Z got 2408 (strictEqual) // /home/runner/work/phantomas/phantomas/node_modules/vows/lib/assert/macros.js:14 2020-08-25T16:36:13.1992620Z ✓ should have "cssCount" metric properly set 2020-08-25T16:36:13.1993080Z ✗ should have "cssSize" metric properly set 2020-08-25T16:36:13.1993540Z » expected 308, 2020-08-25T16:36:13.1993847Z got 331 (strictEqual) // /home/runner/work/phantomas/phantomas/node_modules/vows/lib/assert/macros.js:14 2020-08-25T16:36:13.1994331Z ✓ should have "jsCount" metric properly set 2020-08-25T16:36:13.1994747Z ✗ should have "jsSize" metric properly set 2020-08-25T16:36:13.1995187Z » expected 29730, 2020-08-25T16:36:13.1995501Z got 29753 (strictEqual) // /home/runner/work/phantomas/phantomas/node_modules/vows/lib/assert/macros.js:14 2020-08-25T16:36:13.1995951Z ✓ should have "domains" metric properly set 2020-08-25T16:36:13.1996353Z ✓ should have "DOMqueries" metric properly set 2020-08-25T16:36:13.1996775Z ✓ should have "DOMqueriesById" metric properly set 2020-08-25T16:36:13.1997250Z ✓ should have "DOMqueriesByClassName" metric properly set 2020-08-25T16:36:13.1997703Z ✓ should have "DOMqueriesByTagName" metric properly set 2020-08-25T16:36:13.1998115Z ✓ should have "DOMqueriesByQuerySelectorAll" metric properly set 2020-08-25T16:36:13.1998540Z ✓ should have "DOMinserts" metric properly set 2020-08-25T16:36:13.1999263Z ✓ should have "DOMqueriesDuplicated" metric properly set 2020-08-25T16:36:13.1999925Z ✓ should have "DOMqueriesAvoidable" metric properly set 2020-08-25T16:36:13.2000376Z ✓ should have "DOMqueriesWithoutResults" metric properly set 2020-08-25T16:36:13.2001575Z ✗ should have "gzipRequests" offender(s) properly set 2020-08-25T16:36:13.2002051Z » Expected values to be strictly deep-equal: 2020-08-25T16:36:13.2002452Z + actual - expected 2020-08-25T16:36:13.2002638Z 2020-08-25T16:36:13.2002835Z [ 2020-08-25T16:36:13.2002965Z { 2020-08-25T16:36:13.2003163Z bodySize: 84245, 2020-08-25T16:36:13.2003369Z + transferedSize: 29753, 2020-08-25T16:36:13.2003755Z - transferedSize: 29730, 2020-08-25T16:36:13.2011928Z url: 'http://127.0.0.1:8888/static/jquery-2.1.1.min.js' 2020-08-25T16:36:13.2012192Z } 2020-08-25T16:36:13.2012846Z ] // /home/runner/work/phantomas/phantomas/test/integration-test.js:83 2020-08-25T16:36:13.2013362Z ✗ should have "htmlCount" offender(s) properly set 2020-08-25T16:36:13.2013782Z » Expected values to be strictly deep-equal: 2020-08-25T16:36:13.2014172Z + actual - expected 2020-08-25T16:36:13.2014363Z 2020-08-25T16:36:13.2014535Z [ 2020-08-25T16:36:13.2014707Z { 2020-08-25T16:36:13.2015260Z + size: 2408, 2020-08-25T16:36:13.2015720Z - size: 2385, 2020-08-25T16:36:13.2016127Z url: 'http://127.0.0.1:8888/dom-operations.html' 2020-08-25T16:36:13.2016401Z } 2020-08-25T16:36:13.2016891Z ] // /home/runner/work/phantomas/phantomas/test/integration-test.js:83 2020-08-25T16:36:13.2017326Z ✗ should have "cssCount" offender(s) properly set 2020-08-25T16:36:13.2017744Z » Expected values to be strictly deep-equal: 2020-08-25T16:36:13.2018088Z + actual - expected 2020-08-25T16:36:13.2018264Z 2020-08-25T16:36:13.2018435Z [ 2020-08-25T16:36:13.2018562Z { 2020-08-25T16:36:13.2018747Z + size: 331, 2020-08-25T16:36:13.2019170Z - size: 308, 2020-08-25T16:36:13.2019920Z url: 'http://127.0.0.1:8888/static/style.css' 2020-08-25T16:36:13.2020317Z } 2020-08-25T16:36:13.2020834Z ] // /home/runner/work/phantomas/phantomas/test/integration-test.js:83 2020-08-25T16:36:13.2021265Z ✗ should have "jsCount" offender(s) properly set 2020-08-25T16:36:13.2021686Z » Expected values to be strictly deep-equal: 2020-08-25T16:36:13.2021985Z + actual - expected 2020-08-25T16:36:13.2022172Z 2020-08-25T16:36:13.2022349Z [ 2020-08-25T16:36:13.2022592Z { 2020-08-25T16:36:13.2023011Z + size: 29753, 2020-08-25T16:36:13.2023523Z - size: 29730, 2020-08-25T16:36:13.2024898Z url: 'http://127.0.0.1:8888/static/jquery-2.1.1.min.js' 2020-08-25T16:36:13.2025160Z } 2020-08-25T16:36:13.2025612Z ] // /home/runner/work/phantomas/phantomas/test/integration-test.js:83
Locally:
GitHub:
There's an additional |
macbre
added
bug
Chrome-headless
Tasks related with migration from PhantomJS to Puppeteer's headless Chrome
labels
Aug 25, 2020
Node 14.x adds "Keep-Alive: timeout=5" response header making response sizes less deterministic.
…s failing" This reverts commit d21b814.
And run curl to check it
macbre
changed the title
Run an example script to resolve issues with assets size tests failing
Node.js 14.x integration test are failing on response size asserts
Aug 25, 2020
macbre
changed the title
Node.js 14.x integration test are failing on response size asserts
Node.js 14.x integration tests are failing on response size asserts
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run locally:
When run via GitHub Actions: