Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add timeToLastByte to onLoad and onContentLoad metrics #290

Merged
merged 1 commit into from
Apr 29, 2014
Merged

fix: add timeToLastByte to onLoad and onContentLoad metrics #290

merged 1 commit into from
Apr 29, 2014

Conversation

william-p
Copy link
Contributor

From the spec:

* onContentLoad [number, optional] - Content of the page loaded. Number of milliseconds since page load started (page.startedDateTime). Use -1 if the timing does not apply to the current request.
* onLoad [number,optional] - Page is loaded (onLoad event fired). Number of milliseconds since page load started (page.startedDateTime). Use -1 if the timing does not apply to the current request.

From Phantomas:
Times (windowOnLoadTime, onDOMReadyTime) are relative to responseEnd entry in NavigationTiming (represented by timeToLastByte metric)

I've added timeToLastByte to windowOnLoadTime and onDOMReadyTime metrics.
I'm not sure if my fix is correct, what do you think ?

@macbre macbre added the bug label Apr 29, 2014
@macbre macbre added this to the v1.2 milestone Apr 29, 2014
@macbre
Copy link
Owner

macbre commented Apr 29, 2014

Let's follow the spec :)

macbre added a commit that referenced this pull request Apr 29, 2014
fix: add timeToLastByte to onLoad and onContentLoad metrics
@macbre macbre merged commit 7162f89 into macbre:devel Apr 29, 2014
@william-p william-p deleted the har_timming branch May 12, 2014 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants