Fix timeout error for requests blocked by phantomjs #217
Conversation
ghost
assigned 
| if (entry.isBlocked) { | ||
| return; | ||
| } else { | ||
| phantomas.emit('abort', entry, res); |
There was a problem hiding this comment.
I think it's worth logging this failed request details for debugging purposes as this can indicate problems on PhantomJS side or on the server.
There was a problem hiding this comment.
Agreed.
Shall I investigate a bit more or do you want do it yourself?
There was a problem hiding this comment.
@stefanjudis: please add logging of request URL.
I assume that this issue can be reproduced by:
phantomas --url http://www.nicola-zanon.com/
There was a problem hiding this comment.
Interesting, just tested on the URL above. Works fine, no timeouts (using PhantomJS v1.9.2 / the latest phantomas dev version). Can you post stderr when running in --verbose mode on Gist?
There was a problem hiding this comment.
https://gist.github.com/stefanjudis/22fb165a75d6db5ba94c
It never succeeds.
|
👍 |
Fix timeout error for requests blocked by phantomjs
|
This fix does not work well with base64 encoded data: Will fix it as a part of #216 |
|
👍 |
For this page I noticed the behaviour of constant failing of phantomas.
The reason was, that phantomjs blocks one request and phantomas never counts this request as done.
Result is constant timeout failing.
Referenced issue: stefanjudis/grunt-phantomas#21