Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide metrics metadata in phantomas npm module #224

Closed
macbre opened this issue Jan 22, 2014 · 6 comments
Closed

Provide metrics metadata in phantomas npm module #224

macbre opened this issue Jan 22, 2014 · 6 comments
Assignees
@macbre
Labels
enhancement
Milestone
v1.0

Comments

@macbre
Copy link
Owner

macbre commented Jan 22, 2014

Use metadata file from grunt-phantomas - stefanjudis/grunt-phantomas#24

var phantomas = require('phantomas'),
  metrics = phantomas.metrics; // metadata

@stefanjudis

Data should contain:

  • unit
  • is metric reliable?
  • is metric optional (i.e. requires a specific option to be passed)?
  • are offenders reported?
  • name of the module emitting given metric
@ghost ghost assigned macbre Jan 22, 2014
@stefanjudis
Copy link
Contributor

Perfect! 👍

@stefanjudis
Copy link
Contributor

If it could be extended with units, would be nice actually.

macbre added a commit that referenced this issue Mar 1, 2014
@macbre
windowPerformance: add docs with metrics metadata (#224)
3e6c9d7
macbre added a commit that referenced this issue Mar 1, 2014
@macbre
windowPerformance: add docs with metrics metadata (#224)
36b0d4d
@macbre macbre mentioned this issue Mar 2, 2014
Merged
@macbre
Copy link
Owner Author

macbre commented Mar 2, 2014

@stefanjudis: done, will be released with v1.0

@stefanjudis
Copy link
Contributor

Nice!!! 👍

When are you planning to ship it?

@macbre
Copy link
Owner Author

macbre commented Mar 2, 2014

Documentation and tests require some work before phantomas can be tagged v1.0 - probably 2-3 weeks.

@stefanjudis
Copy link
Contributor

👍

Nice. Thanks for you work! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macbre macbre

Labels
enhancement
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@stefanjudis @macbre