Fix electron moment outputs when using Boltzmann response #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the electron temperature (and corresponding thermal speed) variables were unused, but set equal to the ion temperature, which has the potential to be confusing.
The electron parallel flow is not used when Boltzmann response is used, but most sensible thing is probably to set zero current. This version assumes a single ion species, and sets the electron parallel flow equal to the parallel flow of ion species 1.
The electron moment plots are not helpful in Boltzmann electron runs, as they just replicate ion moments or a constant T_e, so skip those plots.
johnomotani
force-pushed
the
fix-electron-outputs-for-Boltzmann
branch
from
c35de2e
to
afb6ba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set electron temperature to constant when using Boltzmann response - previously the electron temperature (and corresponding thermal speed) variables were unused, but set equal to the ion temperature, which has the potential to be confusing.
Also set electron parallel flow to ion parallel flow (of 'species 1') - again electron parallel flow is unused, but better to set to something sensible for post-processing, etc.
Also skips making plots/animations (in makie_post_processing) of electron moments for Boltzmann electron simulations, as those plots aren't really helpful.
Fixes #252.