Fix MPI linking bug; fix CI tests #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 1.14 of the HDF5_jll package causes a bug (see #148), so set the `[compat]` section of Project.toml to exclude this version (hoping the bug will be fixed by version 1.15 at the latest, some future patch release like 1.14.3 might also be OK though). HDF5_jll is not used directly in moment_kinetics, and so is only included in the Project.toml in order to apply this version restriction. It should probably be removed once the latest version has fixed the bug.
The setup and compilation takes so long, it is not worth running the various debug checks as separate jobs.
This helps to prevent errors in the 'parallel tests' CI job.
The variables only exist in the output file(s) that include the lower or upper boundary respectively, so cannot be loaded on all processes when not using parallel I/O.
Plots.jl has released a new version since the one that caused a problem. The CI job no longer hangs when using the latest version.
Previously, temporary directory was created at pre-compile time and its name saved as a module variable, so would be the same for multiple runs of the test. That would make deleting the output directory to save disk space more complicated. Better to create the temporary directory at run time, so it is different for each test.
This stops the 'parallel tests' hanging in the CI job on macOS.
Removing the brackets ensures that the no-argument version of the function is not declared by mistake, so that trying to call the function with no arguments raises an error (as it should).
The macOS variant keeps timing out with the previous setting.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148 by excluding version 1.14.x of HDF5_jll.jl (that was 'option 2' of #148).
Various fixes so that the CI jobs can all pass again (finally!).
Also includes a bug-fix for I/O of the 'generalised chodura criterion' diagnostic when running in parallel but not using parallel I/O.