Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bound128 #27

Merged
merged 3 commits into from
Mar 1, 2024
Merged

feat: bound128 #27

merged 3 commits into from
Mar 1, 2024

Conversation

deluca-mike
Copy link
Collaborator

No description provided.

@deluca-mike deluca-mike added the enhancement New feature or request label Mar 1, 2024
@deluca-mike deluca-mike self-assigned this Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

Changes to gas cost

Generated at commit: 160f8a967c80581679b416ec544c178d37efec4c, compared to commit: 1d77e263b6f72e257469f843011b2dc4d87e4390

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
UIntMathHarness min240
min32
safe240
safe48
+67 ❌
+66 ❌
-22 ✅
-22 ✅
+7.40%
+7.29%
-3.24%
-3.47%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
UIntMathHarness 786,947 (+24,650) bound240
bound32
min112
min240
min32
safe240
safe48
784 (-22)
784 (-22)
900 (-22)
967 (+67)
966 (+66)
562 (-22)
518 (-22)
-2.73%
-2.73%
-2.39%
+7.44%
+7.33%
-3.77%
-4.07%
784 (-22)
784 (-22)
905 (-22)
972 (+67)
971 (+66)
656 (-22)
612 (-22)
-2.73%
-2.73%
-2.37%
+7.40%
+7.29%
-3.24%
-3.47%
784 (-22)
784 (-22)
905 (-22)
972 (+67)
971 (+66)
656 (-22)
612 (-22)
-2.73%
-2.73%
-2.37%
+7.40%
+7.29%
-3.24%
-3.47%
784 (-22)
784 (-22)
910 (-22)
977 (+67)
976 (+66)
750 (-22)
706 (-22)
-2.73%
-2.73%
-2.36%
+7.36%
+7.25%
-2.85%
-3.02%
1 (0)
1 (0)
2 (0)
2 (0)
2 (0)
2 (0)
2 (0)
SignatureCheckerHarness 1,018,065 (0) isValidECDSASignature(address,bytes32,bytes)
isValidECDSASignature(address,bytes32,bytes32,bytes32)
isValidSignature
recoverECDSASigner(bytes32,bytes)
recoverECDSASigner(bytes32,bytes32,bytes32)
recoverECDSASigner(bytes32,uint8,bytes32,bytes32)
validateECDSASignature(address,bytes32,bytes)
validateECDSASignature(address,bytes32,bytes32,bytes32)
2,271 (0)
1,763 (0)
3,617 (0)
2,000 (0)
1,549 (0)
1,564 (0)
2,134 (0)
1,670 (0)
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
5,042 (+3)
5,076 (+3)
6,205 (+1)
4,289 (+4)
4,392 (+5)
3,853 (+4)
4,905 (+3)
5,052 (+5)
+0.06%
+0.06%
+0.02%
+0.09%
+0.11%
+0.10%
+0.06%
+0.10%
6,149 (+20)
5,641 (+10)
5,268 (0)
5,771 (0)
5,335 (+10)
5,335 (0)
6,012 (+20)
5,548 (+15)
+0.33%
+0.18%
0.00%
0.00%
+0.19%
0.00%
+0.33%
+0.27%
6,159 (0)
5,651 (0)
11,222 (0)
5,801 (0)
5,350 (0)
5,365 (0)
6,022 (0)
5,558 (0)
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
7 (0)
7 (0)
22 (0)
5 (0)
4 (0)
5 (0)
7 (0)
8 (0)

Copy link

github-actions bot commented Mar 1, 2024

LCOV of commit 5d75424 during Forge Coverage #91

Summary coverage rate:
  lines......: 98.5% (133 of 135 lines)
  functions..: 100.0% (51 of 51 functions)
  branches...: no data found

Files changed coverage rate:
                               |Lines       |Functions  |Branches    
  Filename                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================
  src/libs/UIntMath.sol        | 100%     22| 100%    16|    -      0

Base automatically changed from feat/nonces-optimization to main March 1, 2024 17:37
@toninorair toninorair merged commit f447327 into main Mar 1, 2024
2 checks passed
@toninorair toninorair deleted the feat/bound128 branch March 1, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants