Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various informational issues #17

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Conversation

PierrickGT
Copy link
Member

@PierrickGT PierrickGT commented Feb 16, 2024

Issues:

  • Quantstamp MZ-21 Code Documentation

Chainsecurity

Copy link

github-actions bot commented Feb 16, 2024

LCOV of commit def59a3 during Forge Coverage #73

Summary coverage rate:
  lines......: 98.5% (132 of 134 lines)
  functions..: 98.1% (51 of 52 functions)
  branches...: no data found

Files changed coverage rate:
                               |Lines       |Functions  |Branches    
  Filename                     |Rate     Num|Rate    Num|Rate     Num
  ===================================================================
  src/ContractHelper.sol       | 100%      2| 100%     1|    -      0
  src/ERC20Extended.sol        |95.2%     21|88.9%     9|    -      0
  src/ERC712.sol               |94.4%     18| 100%     7|    -      0
  src/ERC712Extended.sol       | 100%      1| 100%     1|    -      0
  src/libs/SignatureChecker.sol| 100%     35| 100%     8|    -      0

Copy link

github-actions bot commented Feb 21, 2024

Changes to gas cost

Generated at commit: 95c94013d7f615f2ec0de263068eed26f0c7fcfc, compared to commit: 160d1058eab98ddb1e0406ae519c13f8b3d9674d

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
ERC20ExtendedHandler burn
mint
-273 ✅
+1,241 ❌
-1.19%
+2.60%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
ERC20ExtendedHandler 1,255,247 (0) burn
mint
transfer
transferfrom
21,660 (-1,140)
20,181 (-1,140)
30,047 (+1,074)
27,054 (-1,162)
-5.00%
-5.35%
+3.71%
-4.12%
22,593 (-273)
48,997 (+1,241)
30,047 (+139)
28,083 (-135)
-1.19%
+2.60%
+0.46%
-0.48%
22,778 (-22)
46,931 (+603)
30,047 (-44)
28,172 (-44)
-0.10%
+1.30%
-0.15%
-0.16%
22,789 (-210)
79,881 (-22)
30,047 (-55)
28,371 (+144)
-0.91%
-0.03%
-0.18%
+0.51%
6 (+3)
3 (-3)
5 (-1)
8 (+3)

@PierrickGT PierrickGT marked this pull request as ready for review February 21, 2024 23:04
src/ERC712.sol Outdated

import { SignatureChecker } from "./libs/SignatureChecker.sol";

/// @title Typed structured data hashing and signing via EIP-712.
/// @dev An abstract implementation to satisfy EIP-712: https://eips.ethereum.org/EIPS/eip-712
abstract contract ERC712 is IERC712 {
abstract contract ERC712 is IERC712, IERC5267 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERC712 does not need ERC5267, but ERC5267 needs ERC712, so this contract can no longer be called ERC712.

There needs to be an IERC712/ERC712, an IERC5267/ERC5267, and ISomething/Something that is both ERC712 and ERC5267. Not sure what Something is, but for now, this contract implements more than ERC712, which is confusing and inaccurate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: a296ca7

@deluca-mike deluca-mike merged commit 0a0cae4 into main Feb 23, 2024
2 checks passed
@deluca-mike deluca-mike deleted the fix/WEB3-739-info-issues branch February 23, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants