-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: various informational issues #17
Conversation
LCOV of commit
|
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
src/ERC712.sol
Outdated
|
||
import { SignatureChecker } from "./libs/SignatureChecker.sol"; | ||
|
||
/// @title Typed structured data hashing and signing via EIP-712. | ||
/// @dev An abstract implementation to satisfy EIP-712: https://eips.ethereum.org/EIPS/eip-712 | ||
abstract contract ERC712 is IERC712 { | ||
abstract contract ERC712 is IERC712, IERC5267 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ERC712
does not need ERC5267
, but ERC5267
needs ERC712
, so this contract can no longer be called ERC712
.
There needs to be an IERC712
/ERC712
, an IERC5267
/ERC5267
, and ISomething
/Something
that is both ERC712
and ERC5267
. Not sure what Something
is, but for now, this contract implements more than ERC712
, which is confusing and inaccurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed: a296ca7
a3690d9
to
22acfcd
Compare
22acfcd
to
def59a3
Compare
Issues:
Chainsecurity