feat: nonces increment optimization

m0-foundation · Mar 1, 2024 · 865cdb0 · 865cdb0
1 parent 0da7d2f
commit 865cdb0
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/ERC20Extended.sol b/src/ERC20Extended.sol
@@ -146,14 +146,14 @@ abstract contract ERC20Extended is IERC20Extended, ERC3009 {
     ) internal virtual returns (bytes32 digest_) {
         _revertIfExpired(deadline_);
 
-        uint256 nonce_ = nonces[owner_]; // Cache `nonce_` to stack.
+        _approve(owner_, spender_, amount_);
 
         unchecked {
-            nonces[owner_] = nonce_ + 1; // Nonce realistically cannot overflow.
+            // Nonce realistically cannot overflow.
+            return
+                _getDigest(
+                    keccak256(abi.encode(PERMIT_TYPEHASH, owner_, spender_, amount_, nonces[owner_]++, deadline_))
+                );
         }
-
-        _approve(owner_, spender_, amount_);
-
-        return _getDigest(keccak256(abi.encode(PERMIT_TYPEHASH, owner_, spender_, amount_, nonce_, deadline_)));
     }
 }