Skip to content

Commit

Permalink
Add guard against null objects. (maplibre#32)
Browse files Browse the repository at this point in the history
MapLibre should error out rather than pass along `null` that can cause exception.

Fix for https://jira.lyft.net/browse/MAPS-42057
  • Loading branch information
roblabs authored Jun 30, 2022
1 parent fa5a0cb commit 7c7454b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lyft-scripts/build-android.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -euo pipefail

# Set the version here! This should be updated on every patch and every MapLibre version change.
readonly VERSION_NAME="9.5.2-patch-5"
readonly VERSION_NAME="9.5.2-patch-6"

# Set the artifact ID, artifact name, & artifactory URL here. This shouldn't change.
readonly ARTIFACT_ID="android-sdk"
Expand Down
2 changes: 1 addition & 1 deletion platform/default/src/mbgl/storage/online_file_source.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class OnlineFileSourceThread {

activeRequests.insert(req);

if (online) {
if (online && req != NULL) {
req->request = httpFileSource.request(req->resource, callback);
} else {
Response response;
Expand Down

0 comments on commit 7c7454b

Please sign in to comment.