Skip to content

Commit

Permalink
[bugfix] fix rows not showing on welcome page (retry) (apache#5849)
Browse files Browse the repository at this point in the history
* fix rows not showing on welcome page

* remove test code

* bring filter back

* remove empty line

* remove another empty line

* remove comment
  • Loading branch information
kristw authored and betodealmeida committed Oct 12, 2018
1 parent a2c0675 commit 393d47d
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 9 deletions.
2 changes: 1 addition & 1 deletion superset/assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
"react-syntax-highlighter": "^7.0.4",
"react-virtualized": "9.19.1",
"react-virtualized-select": "^3.1.3",
"reactable": "1.0.2",
"reactable": "^1.1.0",
"redux": "^3.5.2",
"redux-localstorage": "^0.4.1",
"redux-thunk": "^2.1.0",
Expand Down
1 change: 0 additions & 1 deletion superset/assets/src/welcome/App.jsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint no-unused-vars: 0 */
import React from 'react';
import { hot } from 'react-hot-loader';
import { appSetup } from '../common';
Expand Down
6 changes: 2 additions & 4 deletions superset/assets/src/welcome/DashboardTable.jsx
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
/* eslint no-unused-vars: 0 */
import React from 'react';
import ReactDOM from 'react-dom';
import PropTypes from 'prop-types';
import { Table, Tr, Td, Thead, Th, unsafe } from 'reactable';

import { Table, Tr, Td, unsafe } from 'reactable';
import Loading from '../components/Loading';
import '../../stylesheets/reactable-pagination.css';

Expand Down Expand Up @@ -64,4 +61,5 @@ export default class DashboardTable extends React.PureComponent {
return <Loading />;
}
}

DashboardTable.propTypes = propTypes;
6 changes: 3 additions & 3 deletions superset/assets/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -10292,9 +10292,9 @@ react@^16.4.1:
prop-types "^15.6.2"
schedule "^0.3.0"

reactable@1.0.2:
version "1.0.2"
resolved "https://registry.yarnpkg.com/reactable/-/reactable-1.0.2.tgz#67a579fee3af68b991b5f04df921a4a40ece0b72"
reactable@^1.1.0:
version "1.1.0"
resolved "https://registry.yarnpkg.com/reactable/-/reactable-1.1.0.tgz#2f84bb8b3808df8ac64694b539be416438db8498"

reactcss@^1.2.0:
version "1.2.3"
Expand Down

0 comments on commit 393d47d

Please sign in to comment.